cynkra / munch

Functions for working with the historicized list of communes of Switzerland.
https://munch.cynkra.com
6 stars 2 forks source link

use testthat version 3+ #51

Closed TSchiefer closed 2 years ago

TSchiefer commented 2 years ago

needed a little workaround for checking if a type is factor, cause expect_type() uses type_of and:

factor_var <- factor(c(1,2))
testthat::expect_type(factor_var, "factor")
#> Error: `factor_var` has type 'integer', not 'factor'.
typeof(factor_var)
#> [1] "integer"

Created on 2021-12-02 by the reprex package (v2.0.1)

closes #48

codecov[bot] commented 2 years ago

Codecov Report

Merging #51 (f5158fb) into main (e0b4858) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   71.32%   71.32%           
=======================================
  Files          17       17           
  Lines         701      701           
=======================================
  Hits          500      500           
  Misses        201      201           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0b4858...f5158fb. Read the comment docs.

TSchiefer commented 2 years ago

FYI: test are probably failing cause there was an issue with https://packagemanager.rstudio.com/

krlmlr commented 2 years ago

Thanks!