cynkra / munch

Functions for working with the historicized list of communes of Switzerland.
https://munch.cynkra.com
6 stars 2 forks source link

Running `swc_get_mun_merges()` into the console does not return any output #60

Open andreranza opened 2 years ago

andreranza commented 2 years ago

Running swc_get_mun_merges(2019, canton = "AG") into the console does not return a data.frame or a tibble, conversely to what happens with:

This behaviour is not aligned with those provided by other functions, such as swc_get_mutations() or swc_get_merger_mapping_table()

TSchiefer commented 2 years ago

this seems to be because the last statement in the function is an assignment. SHould work if that assignment is removed. Actually if you assign the result of the function to a variable now it would also work

andreranza commented 2 years ago

Thanks! Yes, if I assign to a variable it works perfectly. However, I wonder if it would be useful to make this function interactive as the others

TSchiefer commented 2 years ago

I agree, the assignment in the function should be removed