search

cynkra / sdtools

tools to work with swissdata sets
1 stars 0 forks source link

added documentation and adjustments to dim_add.R #2

Closed karoliskoncevicius closed 5 years ago

karoliskoncevicius commented 5 years ago

Issuing this pull request for review, to see if I am hitting the spot of what you had in mind.

Also question: what to do about examples? Is there a toy swissdata object available for examples?

christophsax commented 5 years ago

As for the example, this is small (and now in english) and could be added to the data folder, as ch_adecco_sjmi.

https://github.com/christophsax/dstools/blob/master/inst/prepare/ch_adecco_sjmi.R

If you store an object in the data folder (e.g., as .Rdata), with LazyData: true, it will be available as soon as the package is loaded.

christophsax commented 5 years ago

For the other points, see my commit.

christophsax commented 5 years ago

Can you add examples?

karoliskoncevicius commented 5 years ago

@christophsax added data and examples

karoliskoncevicius commented 5 years ago

Also would like to hear your opinion about #3

christophsax commented 5 years ago

Nice, thanks!