Should the interface be changed or left as is?

cynkra / sdtools

tools to work with swissdata sets

1 stars 0 forks source link

Should the interface be changed or left as is? #3

Closed karoliskoncevicius closed 5 years ago

karoliskoncevicius commented 5 years ago

One thing I noticed is that the functions are a bit inconsistent.

For example for dimensions we have dim_add and dim_drop. We discussed that it would also be useful to have level_drop in order to drop only some levels from dimensions.

These point to functions being named in the "object_verb" style. However there is a function relabel which works on both dimensions and levels.

Would it not be better to separate that into dim_rename and level_rename or something of this sort?

christophsax commented 5 years ago

Yes, very good point. Go ahead with dim_rename and level_rename.

christophsax commented 5 years ago

You can close this if you are done.

karoliskoncevicius commented 5 years ago

Will be closed after #6

christophsax commented 5 years ago

Looks good