cynthia / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Please remove windows/google/tcmalloc.h from distribution #398

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I know this may sound strange, but please bear with me for a moment...

I am downloading the source distribution and importing it into ClearCase.  This 
mostly works fine, except for src/windows/google/tcmalloc.h, which creates 
build problems.

The reason it creates build problems is that this header is generated at 
"configure" time from src/windows/google/tcmalloc.h.in, but objects checked in 
to ClearCase (i.e. source files) are not modifiable.

Because this file is generated from the corresponding .in file, there is no 
reason to include it in the distribution at all.  In fact, it will always get 
overwritten if you simply run "configure" in the source tree.  (Compare with 
src/google/tcmalloc.h, which is *not* part of the distribution because it is 
generated from src/google/tcmalloc.h.in.)

So my request is actually trivial:  Handle src/windows/google/tcmalloc.h the 
same way you handle src/google/tcmalloc.h:  Do not include it in the tarball 
because it is a generated file, not a source file.

Thanks :-)

Original issue reported on code.google.com by lopre...@gmail.com on 27 Jan 2012 at 2:24

GoogleCodeExporter commented 9 years ago
The problem is that most windows users, using msvc, don't run configure.

I think the right change is to just update this file by hand for every new 
release, rather than depending on a configure-time check to run it.  So I'll 
get rid of tcmalloc.h.in entirely.  I'm in the middle of preparing a new 
release right now, but I'll see if I can sneak this in.

Original comment by csilv...@gmail.com on 30 Jan 2012 at 10:31

GoogleCodeExporter commented 9 years ago
I've been thinking about this more.  The 'configure' script is run by me, the 
maintainer, when making the .zip file.  You shouldn't be needing to run 
configure for windows -- in fact, the expectation is you wouldn't.  Does 
ClearCase run configure by default?  Can you make it so it doesn't?  I don't 
know anything about ClearCase.

The src/windows/tcmalloc.h that is included in the .zip file (and .tar.gz file) 
is already set up properly to use.  The only reason we include tcmalloc.h.in in 
the distribution is for people who want to submit edits or patches.  Normal 
users can (and should) ignore it.

Original comment by csilv...@gmail.com on 2 Feb 2012 at 7:08

GoogleCodeExporter commented 9 years ago
Well, I am building on Linux.  But "configure" still recurses into the 
src/windows/google directory and tries to re-generate tcmalloc.h.

Original comment by lopre...@gmail.com on 2 Feb 2012 at 7:18

GoogleCodeExporter commented 9 years ago
Come to think of it, I can probably avoid this problem just by using a 
different build directory...  So feel free to close this request.

Sorry for troubling you.

Original comment by lopre...@gmail.com on 2 Feb 2012 at 7:19

GoogleCodeExporter commented 9 years ago
Using a different build directory is a great idea.  I'll close the bug.

Original comment by csilv...@gmail.com on 2 Feb 2012 at 9:53