search

cyntler / hamburger-react

Animated hamburger menu icons for React.js weighs only 1.5 KB.
https://hamburger-react.netlify.app
MIT License
964 stars 36 forks source link

Proposal: Replace default color value with currentColor #14

Closed SeinopSys closed 4 years ago

SeinopSys commented 4 years ago

Following the TypeScript changes I was excited to be able to utilize the package, but I immediately noticed the default value for the color property being slightly non-intuitive.

currentColor is a well-supported value for backgrund-color and other similar CSS properties, referring to the element's current color. Using this value as the default lets developers keep the code DRY while integrating the burger icon with their projects by eliminating the need to duplicate color values that already come from the page's CSS.

luukdv commented 4 years ago

Great idea, thanks again! I'm afraid I'll have to bump the version to 2.0 for this one.