search

cyntler / hamburger-react

Animated hamburger menu icons for React.js weighs only 1.5 KB.
https://hamburger-react.netlify.app
MIT License
972 stars 36 forks source link

fix: make html valid #58

Closed jmdrawneek closed 11 months ago

jmdrawneek commented 2 years ago

Currently you're using divs in buttons which isnt valid html.

Check out - Permitted content


https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button

luukdv commented 2 years ago

Hi!

There’s currently no <button> element used. Can you clarify what you mean?

jmdrawneek commented 2 years ago

Hey @luukdv - even setting a div to role button means the content needs to be an element from that list. Its a very minor change but makes linters happy.

luukdv commented 2 years ago

Interesting! Can you link to the linter config that warns for this? Would be helpful for me to be able to test as well.