v2.0.0 - Githubissues

cyon / vue-translation-manager

Interactively translate strings in Vue single file components

26 stars 12 forks source link

Open MaxGfeller opened 5 years ago

MaxGfeller commented 5 years ago

This is the draft PR for v2.0.0. The new changes can be seen in the CHANGELOG.md.

Here are the things that still have to be done:

[ ] Handle literals in script blocks
[ ] Fix coding style issues
[ ] Fix failing tests
[ ] Make it possible to not translate a specific string in interactive mode, e.g. by pressing Esc

Znarkus commented 2 years ago

Tested this on Node v16.13.1 in my project. I get crashes on these lines:

It seems that it assumes that node.value is always string, and doesn't handle numbers, boolean etc. Might this be a change in recent NodeJS?

It's trying to do trimStart() on this node.value:

<ref *2> Node {
  type: 'Literal',
  value: true,

and trim() on this:

<ref *2> Node {
  type: 'Literal',
  value: 1,
  raw: '1',