cyotek / Cyotek.Windows.Forms.ColorPicker

Color picker control suite for Windows Forms applications.
http://cyotek.com/blog/tag/colorpicker
MIT License
150 stars 41 forks source link

Add NET Core and NET 5 support. #21

Closed VPKSoft closed 3 years ago

VPKSoft commented 3 years ago

Side-effects:

Other:

cyotek commented 3 years ago

Hello,

Thanks for this PR. I've decided not to accept it for various reason - every file seems to have changed for example (whitespace issues?) and some of the corrections aren't the way I would have done them (for example the compile error due to the static type). The main reason though was I've been migrating many of our internal projects to multi-targeted SDK libraries and this is the first one I've got to that used Windows Forms. As a result, I wanted to do this myself by hand in order to determine any issues that I will encounter when converting the large number of other projects I need to process (for example dotbuild with resx files doesn't work and I need to find a better solution that deleting the resx files ;) ).

There is a branch in this repro called dotnet50 which includes a smaller set of changes to convert to multi-target SDK (targets 3.5, 4.0, 4.5.2, 4.6.2, 4.7.2, 4.8 and 5.0 (which I will hopefully merge in this week after doing some more testing, and potentially adding in .NET Core 3.1 which I forgot about).

Thank you again for the PR, I'm sorry I wasn't able to accept it this time.

Regards; Richard Moss