search

cypai / wf

My former game project, the Wishing Project. Written in Java.
Apache License 2.0
2 stars 0 forks source link

Rifle #2

Open theazuresoul opened 9 years ago

theazuresoul commented 9 years ago

Implemented Rifle class. Please review.

cypai commented 9 years ago

First, make sure all unit tests pass. PrecisionShotCooldown test is failing.

cypai commented 9 years ago

Please also setup checkstyle to catch the issues found on the line comments. I know that some of my code has checkstyle issues too (will be fixed in a future commit), but let's not add more when we can keep it maintainable fairly easily.

theazuresoul commented 9 years ago

Fixed the unit test issue. Forgot to modify after adding the weapon requirement check.

cypai commented 9 years ago

Let's get rid of those 3 commits by squashing them.

cypai commented 9 years ago

Please set your eclipse formatter to wf_formatter.xml

cypai commented 9 years ago

Because of the recent Configuration, Dependency Injection, and Test Suite Reorganization refactor, there may be some serious merge conflicts. During your next rebase to master, please make sure everything is correct (especially your Ability test needs to be moved to a different file, probably SnapShotAbilityTest.java in the com.pipai.wf.unit.ability package)