search

cyperdark / osu-api-extended

Package for advanced work with "osu" api
MIT License
47 stars 16 forks source link

Refactor user authorization functions #17

Closed yorunoken closed 9 months ago

yorunoken commented 11 months ago

closes #15

yorunoken commented 9 months ago

bump

GabuTheDev commented 9 months ago

You missed something that I've mentioned in #15

method is not an object property, but a different parameter (the first one to be exact). so the function will take 2 parameters: method and an object that contains the login informations.

the code example in your original comment was good, idk why you've changed it.

(I'm just saying you did not follow my original suggestion; depends on cyperdark if he wants to go with this version or the original version)

cyperdark commented 9 months ago

not planned in v2, will implement in v3

yorunoken commented 9 months ago

@GabuTheDev wouldn't it make more sense to put method inside the object? That's the reason why I put it there

GabuTheDev commented 9 months ago

@GabuTheDev wouldn't it make more sense to put method inside the object? That's the reason why I put it there

not really. I grouped the parameters based on types. method have no correlation to login info. Also I requested this just because every popular package works in the same way so it's not just my preference but an overall usage.