search

cyph / pqcrypto.js

MIT License
29 stars 6 forks source link

Fixing TS1016 when using TypeScript on package `superdilithium` #8

Open BadAimWeeb opened 1 year ago

BadAimWeeb commented 1 year ago 
node_modules/superdilithium/index.d.ts:105:4 - error TS1016: A required parameter cannot follow an optional parameter.

105    includeHash: true
       ~~~~~~~~~~~

node_modules/superdilithium/index.d.ts:129:4 - error TS1016: A required parameter cannot follow an optional parameter.

129    includeHash: true
       ~~~~~~~~~~~

node_modules/superdilithium/index.d.ts:185:4 - error TS1016: A required parameter cannot follow an optional parameter.

185    includeHash: true
       ~~~~~~~~~~~

Found 3 errors in the same file, starting at: node_modules/superdilithium/index.d.ts:105

So I changed it to be

includeHash?: boolean

instead since that's what it supposed to be.