search

cypher / git-ruby-syntax-check

Checks the syntax of all changed ruby files is valid before allowing a commit
MIT License
70 stars 16 forks source link

getting warning in rails rspec '.should ==' #6

Closed AdrianFlorian closed 10 years ago

AdrianFlorian commented 10 years ago

It does not seem to work with this synthax:

failed_advert.url.should == advert_candidate.url

I'm getting 

 warning: possibly useless use of == in void context
AdrianFlorian commented 10 years ago

Ok, turns out the issue popped up because I've updated some specs which had something like:

      failed_advert.exception_message.should == exception.message
      failed_advert.exception_class.should == exception.class.name
      failed_advert.from_rescraper.should == true
      failed_advert.last_seen_at.should == time

Since this is something not recommended by rspec, I think the warning is valid. I'm closing this