search

cypherstack / stack_wallet

Stack Wallet, a multicoin, cryptocurrency wallet
https://stackwallet.com
GNU General Public License v3.0
162 stars 53 forks source link

Allow Restoring Wallet From File #73

Open HardenedSteel opened 1 year ago

HardenedSteel commented 1 year ago

Especially for Monero being able to restore from wallet file is important because it allows to skip synchronization process.

mvozzo commented 1 year ago

I think this is a brilliant idea, however, I'd like some clarification on this enhancement.

If I can restore wallet via a file, would this negate the need for seed phrases?
If this is the case, I would like to insist that these be a mandatory Restore Wallet "Password" associated with the Wallet file otherwise this would be a BIG security risk. If there isn't a Restore Wallet File Password, this would mean someone gets hold of a restore Wallet file, they could gain access to all my crypto without any need for seed phrases.

On a side note, what I'd like to see backed up within the Wallet Restore File is 2 main things 1) Restore all the meta data contained in "Transaction Notes".
2) Restore all the different wallet setting such a custom node configurations etc. Hence, in the event I need to migrate my Stack Wallet to a new phone, I simply restore via Wallet file and all my "Notes" and config are in tact saving me time and everything will appear as before.

Thanks.

sneurlax commented 1 year ago

@HardenedSteel for Monero and Wownero we can generate or restore from .keys files like monero-wallet-cli.exe --wallet-file wallet-name.keys as in this discussion. I would need to check into the process for importing Bitcoin-based wallets before answering whether restoring wallets from files is feasible for them.

HardenedSteel commented 1 year ago

@sneurlax importing from .keys file wont be useful and still people will have to sync their wallet from scratch