search

cypherstack / stack_wallet

Stack Wallet, a multicoin, cryptocurrency wallet
https://stackwallet.com
GNU General Public License v3.0
213 stars 60 forks source link

Filter unrecognized from extra URI parameters IAW BIP21 #935

Closed sneurlax closed 2 months ago

sneurlax commented 4 months ago

Closes https://github.com/cypherstack/stack_wallet/issues/567

Tasks:

TODO refer to BIP21 to see if any other params are required

sneurlax commented 4 months ago

Converted to draft pending more testing. Or we can merge and test w/ testers :)

sneurlax commented 4 months ago

Tested and this mostly works, but the address is considered invalid after pasting it: Screenshot from 2024-07-16 10-45-02

So this needs more work. It's a valid address, I got it from the Receive screen and added ?asdf as in bitcoincash:qp07gms9yzj9ykj74ervscc8zd89gwe23cark3uk2r?asdf

I also need to make sure that mobile send screens--and really all opportunities to paste URIs--are covered by this PR's logic.

julian-CStack commented 4 months ago

We should expand on the parse util to handle various types of payment uris (bitcoin based, monero based, etc). There are more than 3 valid keys/params in the standards so this needs some more work for sure. The parsing of the uri should be centralized and return a common object with the values required for the gui.

The PR currently only affects the main desktop send screen. Nothing on mobile and possibly other send screens on desktop will not work with this either at the moment.

sneurlax commented 2 months ago

Re:

Tested and this mostly works, but the address is considered invalid after pasting it ... So this needs more work. It's a valid address, I got it from the Receive screen and added ?asdf as in bitcoincash:qp07gms9yzj9ykj74ervscc8zd89gwe23cark3uk2r?asdf

This issue has been resolved by b73628d939429119b2f296e9456902a4db370e3d