cypherstack / stack_wallet

Stack Wallet, a multicoin, cryptocurrency wallet
https://stackwallet.com
GNU General Public License v3.0
213 stars 60 forks source link

Bug: [Campfire|Stack] FIRO Transaction fee not shown at Send screen #948

Closed justanwar closed 3 months ago

justanwar commented 4 months ago

Is there an existing issue for this?

Current Behavior

Transaction fee (estimated): Average always shows 0.00000000 FIRO ~12.5 minutes regardless of network conditions and average block time (2.5 minutes)

Confirm FIRO transaction screen shows the correct amount however for both Spark and transparent sends.

Expected Behavior

For the transaction fee to be shown at the Send screen.

Reproduce Steps

Send Firo to a Spark or Transparent address

Environment

Logs

No response

Further Information

image

image

julian-CStack commented 3 months ago

The call to the ffi lib's spark fee estimate function wasn't hooked up. This was just added. The fee shown on the send screen is an estimate and as such may not be quite accurate. Always rely on the the displayed fee on the confirm tx screen. Estimation may not be 100% accurate for performance reasons. If it is consistently and significantly different once this commit is in the next release please reopen this issue.