cypht-org / cypht

Cypht: Lightweight Open Source webmail aggregator [PHP, JS]
http://cypht.org
GNU Lesser General Public License v2.1
949 stars 146 forks source link

jonocodes/cypht container comments (latest/v2.0.1-wip) #1049

Open truthsword opened 1 month ago

truthsword commented 1 month ago

I was asked to try this image (originally I used sailfrog's image). In some ways this regressed for me. Rather than open multiple question posts, I have captured my initial impressions here.

I have used both jonocodes/cypht:latest and jonocodes/cypht:2.0.1-docker-wip image tags. The latest image gave me white screens when clicking the “Site” setting icon. The 2.0.1-docker-wip image displayed properly in the browser.

Findings:

marclaporte commented 1 month ago

Thank you @truthsword. This is very helpful.

I suspect all these issues come from 2 or 3 root causes.

@jonocodes is away from the keyboard for a few days and I am at Open Source events for the upcoming 2 weeks: https://tiki.org/TikiFestParis2024 so things will slow down a bit.

But @josaphatim will release Cypht 2.1.0 soon: https://github.com/cypht-org/cypht/issues/1050

And we will all make sure that https://hub.docker.com/u/cypht is as good as a manual install. We'll encourage the active developers to use it as much as possible.

jonocodes commented 1 month ago

Great info @truthsword . Thanks for testing.

Can you confirm that all these points are working with the old sailfrog image? And more importantly, if you have the resources, could you test to see if these are issues in master without docker?

@marclaporte what are the 2 or 3 causes guess?

truthsword commented 1 month ago

Can you confirm that all these points are working with the old sailfrog image

Some were, some weren't, some were “broken” in different ways. Going by memory… What worked in sailfrog, was

What did not work in sailfrog,

could you test to see if these are issues in master without docker

I don't have a test machine to do that. Docker is simpler for me.

marclaporte commented 1 month ago

what are the 2 or 3 causes guess?

@truthsword compared legacy Docker recipe with 5 month old code from master vs new Docker recipe and latest code. Hypothesis: bugs emanate from either:

1- A side effect of https://github.com/cypht-org/cypht/pull/625 which is a massive revamp/cleanup 3 months ago in master. I expect breakage but things will be much easier to fix now because this new design is more robust.

2- Something needs an adjustment in the new Docker recipe. Ex.: something is hard-coded to off.

resource folder mappings were ignored and populated with seemingly random email folders. For example, Trash and Junk folder resources contained the draft folders from multiple email accounts.

I saw this and it was fixed. @truthsword was seeing because sailfrog Docker image has old code.

IMAP subfolders were not present for manually configured IMAP accounts.

I don't remember seeing this nor it being fixed, so I suspect it's just a regular bug. A good one for @Shadow243 to assign to one of the new devs as a training exercise :-)

marclaporte commented 2 weeks ago

@truthsword I expect some of the issues will be solved in Cypht 2.1.0 which should be available via Docker soon: https://github.com/cypht-org/cypht/issues/1047#issuecomment-2176529867