search

cypht-org / cypht

Cypht: Lightweight Open Source webmail aggregator [PHP, JS]
http://cypht.org
GNU Lesser General Public License v2.1
979 stars 154 forks source link

Update .gitignore to exclude Docker's persistence directory #1057

Closed Yannick243 closed 3 months ago

Yannick243 commented 3 months ago

Docker's persistence folder (data) was not being ignored.

This is a small update to https://github.com/cypht-org/cypht/pull/1001

jonocodes commented 3 months ago

How are you running docker exactly? Are you running the sample yaml file directly in the docker directory perhaps? Are you running this in production or development?

Yannick243 commented 3 months ago

My bad, i was running it directly in the docker directory.

Yannick243 commented 3 months ago

Hello @jonocodes; I think this is this still relevant, as some people may run Docker directly from the Docker directory? Or am I mistaken?

jonocodes commented 3 months ago

Hello @jonocodes; I think this is this still relevant, as some people may run Docker directly from the Docker directory? Or am I mistaken?

I didnt think of that use case, but yeah it can be relevant since it may be a way people use it. I am considering changing the name of the file to docker-compose.prodexample.yaml to make it a little more clear also.

marclaporte commented 3 months ago

So what is the next step?

jonocodes commented 3 months ago

I approved it. It can be merged.