search

cypht-org / cypht

Cypht: Lightweight Open Source webmail aggregator [PHP, JS]
http://cypht.org
GNU Lesser General Public License v2.1
979 stars 154 forks source link

[ENH] add functionality to send later scheduled sending #1091

Open amaninyumu1 opened 3 months ago

amaninyumu1 commented 3 months ago

issue issue

marclaporte commented 3 months ago

Will this work with JMAP as well?

kroky commented 3 months ago

Yes, anything we add for IMAP, we should check JMAP support as well. Overall, it is built on top of IMAP, so it should work but please check if the new Scheduled folder is OK for JMAP.

Overall, the code is good but I have one concern - it only sends out while you are actively using Cypht and it seems to warn of unsent/scheduled messages each time you leave a page (onbeforeunload). That would be annoying for the end user. I believe this comment https://github.com/cypht-org/cypht/issues/576#issuecomment-2119670366 proposes using sendAt support from jmap servers or scheduled send - if it is supported, we use it, if not, we fallback to a more annoying option. At any rate, it should be configurable.

This could be fully-supported in the Cypht-Tiki integration where there could be a Tiki command run periodically in the scheduler that checks and sends scheduled messages.

josaphatim commented 3 months ago

@kroky I added a commit to fix issue concerning onbeforeunload event and also add the option to change schedule time or send the message immediately. Can you check please.

marclaporte commented 2 months ago

@amaninyumu1 If you need help with JMAP, please reach out to @Shadow243 as he set up a JMAP server for testing.

marclaporte commented 1 month ago

@amaninyumu1 "This branch has conflicts that must be resolved"