search

cypht-org / cypht

Cypht: Lightweight Open Source webmail aggregator [PHP, JS]. Supports IMAP/SMTP, JMAP and soon EWS
http://cypht.org
GNU Lesser General Public License v2.1
1.01k stars 164 forks source link

Some HTML messages can't be closed (was "Inline message", where is the setting?) #1155

Closed europacafe closed 3 months ago

europacafe commented 3 months ago

Cypht 2.1.0 docker (using Stalwart mail server docker)

From the Inline Message module readme, I went to the Site/General setting page, but I did not see its setting parameter. I've checked the modules folder, it is there. image

even I manually edit the env file to turn it to "true", it didn't show inline message image

image

image

marclaporte commented 3 months ago

@christer77 Please figure this out.

christer77 commented 3 months ago

even I manually edit the env file to turn it to "true", it didn't show inline message

Hello @europacafe,

Among the list of modules present in the environment variable _CYPHTMODULES in .env file; Can you confirm that you have _inline_message_ in this list?

europacafe commented 3 months ago

thank you very much. You are right. After adding it in the env file, it is working now.

europacafe commented 3 months ago

One more thing. Most inline messages work great, they have an 'x' button on the upper right for closing the expanded message. However, some html messages don't have such 'x' icon; thus can't close; even I scrolled horizontally to the right-most part of the html page. image

christer77 commented 3 months ago

One more thing. Most inline messages work great, they have an 'x' button on the upper right for closing the expanded message. However, some html messages don't have such 'x' icon; thus can't close; even I scrolled horizontally to the right-most part of the html page. image

We tried to reproduce the issue, you're right, now we're going to do it

Shadow243 commented 3 months ago

@europacafe can you confirm on your side after this PR: https://github.com/cypht-org/cypht/pull/1172 please!

europacafe commented 3 months ago

@europacafe can you confirm on your side after this PR: #1172 please! Thanks for the fix. I believe you fix it on the master code; but I'm running v.2.1.0, not the master.

For the modules/imap/site.js file, when I opened it for manual amendment/fix, line 837 is not the same as yours, so I believe it is not the same version as yours before the fix.

I rather wait till the official release upgrade.