search

cypht-org / cypht

Cypht: Lightweight Open Source webmail aggregator [PHP, JS]. Supports IMAP/SMTP, JMAP and soon EWS
http://cypht.org
GNU Lesser General Public License v2.1
1.01k stars 161 forks source link

DEFAULT_SETTING_TEXT_ONLY's comment & default value are inconsistent #1315

Closed Denperidge closed 1 week ago

Denperidge commented 2 weeks ago

🐛 Bugreport

In the current version of app.php (line 1026), the comment includes "Defaults to false", while the php env default is set to true

Version & Environment

Rev: [abdd8aab4284967bf676a3f8fdbc37c793120f51]

marclaporte commented 2 weeks ago

@Denperidge Thank you for the reports (this and the other one). I suggest you make merge requests for things like this, and you will be listed as a contributor of Cypht 2.5.0!

Denperidge commented 2 weeks ago

@marclaporte Much appreciated! Could you (or someone else with more experience developing Cypht than me) advise on what the correct default value is? (Both for the value in app.php and .env.example? Although with the latter I assume the false value is the correct one)

marclaporte commented 1 week ago

@Denperidge Please confirm in latest master

Denperidge commented 1 week ago

Looks perfect! Closing issue 😌