"Sign" for signature (profiles) does not work for HTML signatures (plain text is OK)

[robert-winkler]

🐛 Bugreport

Created profiles work (email, Display name and servers), but the Signature cannot be included into Emails.

Version & Environment

1664 Jul 19 20:04 composer.json OS: Ubuntu 18.04.3 LTS

Steps to reproduce

1. Create profile with signature
2. Compose E-mail and click "Sign". The button reacts, but no signature is included.
3. Send
4. The received E-mail does not contain a signature.

Importance

Low. But for business communication, a signature would be very nice.

Feature

HTML signatures would be very nice.

[jasonmunro]

This works for me, so I'm not sure what is up. Can you see if there are any JS errors when you try to sign a message? Thanks!

[robert-winkler]

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512

Hi Jason,

Thanks for attending my reports. Where can I monitor/ log the JS errors? I am running Cypht on a Ubuntu Ubuntu 18.04.3 LTS webserver.

Best regards,

Robert

Jason Munro notifications@github.com wrote:

This works for me, so I'm not sure what is up. Can you see if there are any JS errors when you try to sign a message? Thanks!

---

Robert Winkler

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRujpWQ/v2xE00/+4Z82ycOpoE0FwUCXcrBpwAKCRB82ycOpoE0 FzacAP401QBbtlbo+zJFzFfBAcVdhwjATxBb8YBs1VJIihNOiAEAwnrjn4p6XPjb +e2oTMSe5hVxesZgNOS6bSfZVFu/kwY= =SvGQ -----END PGP SIGNATURE-----

[jasonmunro]

Hi Robert, Thanks for the quick follow up. you can find Javascript errors in your browser, if you are using Chrome or Firefox the "dev console" will show any JS errors. These errors might pop up when you load the compose page, or after clicking "Sign". Another option is to view the source of the compose page and find a section like so:

<script type="text/javascript">var profile_signatures = {0.1: "foo"}</script>

(of course with your signature and not "foo"). It will be in the second have the source. If you can post that here I can test with it and try to reproduce. If that is not present and there are no JS errors, something else is going wrong so we will have to keep digging.

Thanks!

[jasonmunro]

@robert-winkler I deleted your response because I think it had more personal information than you may have meant to share to solve this problem. I have a copy of the text I can use to troubleshoot the issue. Thank you for the quick follow up!

[jasonmunro]

@robert-winkler tested your signatures and they appear to work fine for me, however signatures only work when composing with plain text, when composing with HTML nothing happens. I'm going to see if I can fix that at least until we can support HTML signatures. Can you confirm that if you change your outbound mail format to plain text the "SIgn" button works? It works here so if not there is something else amiss.

Thanks!

[drh8ball]

Hi, I found this talk, because I was searching for html signature. How is your progress with the html signature? Can I help you in any way?

[marclaporte]

@robert-winkler We need you!

[marclaporte]

@robert-winkler This is slated for Cypht 1.2 release!

[robert-winkler]

Hi, indeed, plain text signatures work.

[jasonmunro]

As always thank you @robert-winkler for your support but I am going to remove this from the release backlog. Needs fixed but not worth holding up the release.

[marclaporte]

@robert-winkler

Please retest, as a lot has changed since you reported this issue. Notably, we now have 3 active branches and recently released Cypht 2.0.0

• https://github.com/cypht-org/cypht/releases/tag/v2.0.0
• https://github.com/cypht-org/cypht/wiki/Lifecycle