Added CREATE TABLE statements into config/database.php

cypht-org / cypht

Cypht: Lightweight Open Source webmail aggregator [PHP, JS]

http://cypht.org

GNU Lesser General Public License v2.1

980 stars 154 forks source link

Added CREATE TABLE statements into config/database.php #983

Closed PaulTGG closed 5 months ago

PaulTGG commented 5 months ago

Pullrequest

Added CREATE TABLE statement examples into the config/database.php. (The statements are referenced at the start of the file, but they weren't included in the file.)

Issues

[X] None

Checklist

[x] None

How2Test

[X] None

Todo

[X] None

PaulTGG commented 5 months ago

Thank you @PaulTGG. By adding it here, we ensure clarity and ease of location for future reference. However, please be mindful to remove the previous instance at: https://github.com/cypht-org/cypht/blob/master/config/app.php#L618 to avoid duplication.

Where is the best place for that info? Should it be in the app.php, or in the database.php? If the former, then I'll close the PR. If the latter, then the line at the top of database.php mentioning the sql statements should be removed.

Shadow243 commented 5 months ago

Thank you @PaulTGG. By adding it here, we ensure clarity and ease of location for future reference. However, please be mindful to remove the previous instance at: https://github.com/cypht-org/cypht/blob/master/config/app.php#L618 to avoid duplication.

Where is the best place for that info? Should it be in the app.php, or in the database.php? If the former, then I'll close the PR. If the latter, then the line at the top of database.php mentioning the sql statements should be removed.

Instinctively, in database.php, especially since there is not too much data there so it is clear and easy to find.

PaulTGG commented 5 months ago

@Shadow243 app.php is updated.

Shadow243 commented 5 months ago

@PaulTGG I don't understand why I see 3 commits instead of 2, did you do a local rebase ?

PaulTGG commented 5 months ago

@PaulTGG I don't understand why I see 3 commits instead of 2, did you do a local rebase ?

Yes, there was a non-conflicting commit I added to my fork. (This is my first time contributing to a github project, so I'm still figuring things out... XD)

Shadow243 commented 5 months ago

@PaulTGG I don't understand why I see 3 commits instead of 2, did you do a local rebase ?

Yes, there was a non-conflicting commit I added to my fork. (This is my first time contributing to a github project, so I'm still figuring things out... XD)

Oh it's good now I just removed the other commit and then rebase with git pull --rebase https://github.com/cypht-org/cypht.git master

Shadow243 commented 5 months ago

Since we've merged the changes, we'll need to update the documentation accordingly at: https://www.cypht.org/install-2x.html