search

cypht-org / cypht

Cypht: Lightweight Open Source webmail aggregator [PHP, JS]
http://cypht.org
GNU Lesser General Public License v2.1
980 stars 154 forks source link

"Allow Images" link missing/hidden #985

Closed PaulTGG closed 5 months ago

PaulTGG commented 5 months ago

🐛 Bugreport

Version & Environment

Rev: 57756bc

OS: Debian 12.5

Steps to reproduce

  1. Install latest master.
  2. Look at an email that has images.
  3. There's no link to allow images.

Issue https://github.com/cypht-org/cypht/pull/873 was designed to allow images from a particular sender, but if the link is there it isn't obvious where.

marclaporte commented 5 months ago

@jacob-js please advise :-)

PaulTGG commented 5 months ago

@jacob-js More info - the links are only missing from the inline view. Both links (allow, and always allow) appear in the not-inline view.

jacob-js commented 5 months ago

@jacob-js More info - the links are only missing from the inline view. Both links (allow, and always allow) appear in the not-inline view.

This could probably be the case. Let me give it a look. Thanks @PaulTGG

jacob-js commented 5 months ago

@PaulTGG please help me! How do you toggle the inline view?

PaulTGG commented 5 months ago

@jacob-js I use these settings: setting

...and I open the email from the inbox by clicking on the subject line: inlineview

jacob-js commented 5 months ago

@PaulTGG suprisingly I don't have such settings.

Screenshot Settings

I don't understand. Is your version other than the latest master?

PaulTGG commented 5 months ago

@jacob-js I'm running the latest master: 492f634. Also, I did not do an in-place upgrade. I use a database, and my database didn't change, but the front-end cypht folder was completely rebuilt from scratch.

PaulTGG commented 5 months ago

@jacob-js Do you have the "inline_messages" module active in your .env file? That module is missing from the .env.example file, so you'd have to add it manually.

jacob-js commented 5 months ago

@jacob-js Do you have the "inline_messages" module active in your .env file? That module is missing from the .env.example file, so you'd have to add it manually.

Thank you! This one fixed. I re-confirm the reported issue, let's fix...

jacob-js commented 5 months ago

Closing the issue, a PR has been created. https://github.com/cypht-org/cypht/pull/1002