search

cypress-io / circleci-orb

Install, cache and run Cypress.io tests on CircleCI with minimal configuration.
https://circleci.com/orbs/registry/orb/cypress-io/cypress
MIT License
161 stars 101 forks source link

feat: change default executor to cypress/base:12.19.0 #337

Closed flotwig closed 3 years ago

flotwig commented 3 years ago

With Cypress 7, the orb fails with the default configuration, since Node 10 is no longer supported by Cypress:

https://app.circleci.com/pipelines/github/cypress-io/angular-pizza-creator/319/workflows/a777b065-1cdd-46a5-8d2b-1abcbc711412/jobs/321

This PR updates the default executor to use Node 12 so that it works ootb with Cypress 7.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

bahmutov commented 3 years ago

should we just set it to node 14 already?

flotwig commented 3 years ago

12 is the minimum required by Cypress 7.

flotwig commented 3 years ago

@bahmutov how can i update these snapshots? i tried running npm run manual:tests -u locally, but i get errors like this for all tests:

image

same for npm test

bahmutov commented 3 years ago

I just think it is weird to change to Node 12 to bare minimum version rather than LTS version?

flotwig commented 3 years ago

Wasn't it Node 10 previously because that was the minimum required by Cypress? This is keeping with tradition. I guess we could switch to using the latest LTS but I don't see why it matters one way or the other

bahmutov commented 3 years ago

I think the tradition was only an artifact of Node 12 being released :) Keeping to 12.0.0 is like asking someone to install Cypress v6 and they install specifically Cypress v6.0.0 and you are like "why...." There are lots of fixes and features in the LTS compared to the first major release. I say, let me make this PR on top of the latest 12 we have.

flotwig commented 3 years ago

Updated to cypress/base:12.19.0.

bahmutov commented 3 years ago

Yeah, let me update the snapshots

flotwig commented 3 years ago

https://github.com/cypress-io/circleci-orb/pull/339