search

cypress-io / circleci-orb

Install, cache and run Cypress.io tests on CircleCI with minimal configuration.
https://circleci.com/orbs/registry/orb/cypress-io/cypress
MIT License
160 stars 101 forks source link

Allow to set circleci_ip_ranges to use known IP ranges #356

Open rickythefox opened 3 years ago

rickythefox commented 3 years ago

CircleCI now provides a flag for using known IP ranges. This can be helpful when testing firewalled environments, e.g. staging environments. See https://circleci.com/docs/2.0/ip-ranges/. This is achieved by setting circleci_ip_ranges: true on the job.

My feature request is to enable this in the orb as an optional setting.

I can submit a PR if this is of interest.

arvid-m commented 3 years ago

This feature would be very useful! It's currently blocking us from using the orb.

vcmuner commented 2 years ago

would be very useful indeed, I'm about to stop using the orb because of this

Zach-Costa commented 2 years ago

Is this still in progress? My team is looking to get this implemented for our runs, but we'd like to keep using the orb if possible.

chiraggshah commented 1 year ago

I would like to use this, but there seem to be no updates.

jennifer-shehane commented 1 year ago

I believe passing CircleCI params to the orb should work. Please try upgrading to v3.0.0 of the orb. Please comment if this is still occuring.

rickythefox commented 1 year ago

Just realised I solved this problem in a different way and forgot my offer to submit a PR. It still stands if v3.0.0 does not solve the issue.

james-luther commented 1 year ago

I'm having this issue currently and am not sure how to pass this param to the orb. I am using an anchor to define the job and not able to pass it correctly. I'm not sure if this is just unsupported or if there is a syntax error. I'm receiving Unexpected argument(s): circleci_ip_ranges

tmannherz commented 6 months ago

You can't pass circleci_ip_ranges to the cypress/run job (it'll throw the Unexpected argument... error) but instead would need to explicitly define your own jobs that call the same commands as cypress/run:

version: 2.1
orbs:
  cypress: cypress-io/cypress@3.3.1
jobs:
  run:
    executor: cypress/default
    circleci_ip_ranges: true
    steps:
      - cypress/install:
          working-directory: ./
      - cypress/run-tests:
          working-directory: ./
workflows:
  run-tests:
    jobs:
      - run