search

cypress-io / circleci-orb

Install, cache and run Cypress.io tests on CircleCI with minimal configuration.
https://circleci.com/orbs/registry/orb/cypress-io/cypress
MIT License
160 stars 101 forks source link

fix: only attach workspace when required #363

Closed willheslam closed 1 year ago

willheslam commented 2 years ago

My cypress/run CI job is currently failing due to

Directory (/home/circleci/project) you are trying to checkout to is not empty and not a git repository because the following steps are always applied:

- attach_workspace:
at: ~/
- checkout

checkout should only be present when you're not attaching a workspace, but currently, attach-workspace: false doesn't stop workspaces being attached due to the broken conditional, hence the job failing if the workspace has anything inside it.

Fixes https://github.com/cypress-io/circleci-orb/issues/293

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

jennifer-shehane commented 2 years ago

@willheslam Could you please sign our CLA?

willheslam commented 2 years ago

@jennifer-shehane Oops, thanks for the reminder - done!

bayphillips-seed commented 1 year ago

Hey @pckilgore any chance this could be merged in? We're running into this issue currently.

pckilgore commented 1 year ago

Hey @pckilgore any chance this could be merged in? We're running into this issue currently.

Don't work for Cypress

benedfit commented 1 year ago

Do you have an ETA for when this will be released?