search

cypress-io / circleci-orb

Install, cache and run Cypress.io tests on CircleCI with minimal configuration.
https://circleci.com/orbs/registry/orb/cypress-io/cypress
MIT License
161 stars 101 forks source link

Can we get a node-16 executor? #368

Closed adam-lynch closed 2 years ago

adam-lynch commented 2 years ago

There should be an executor to run on node 16. The max is 14 according to https://circleci.com/developer/orbs/orb/cypress-io/cypress#executors.

I haven't ran into an issue yet but we've had some local issues with our postinstall scripts on node 14 so we're bumping to 16 and I want to run the Cypress job on 16 too.

See https://nodejs.org/en/about/releases/; node 16, 17, and 18 should probably be supported.

essential-randomness commented 2 years ago

Came here to ask the same thing :)

FinnLawrence commented 2 years ago

For anyone who needs Node 16 support in the meantime, I have set our builds up to use a customised docker executor from Cypress's list here: https://github.com/cypress-io/cypress-docker-images/tree/master/browsers

Example config:

version: 2.1
orbs:
  cypress: cypress-io/cypress@1.29.0
executors:
  with-chrome:
    resource_class: small
    docker:
      - image: "cypress/browsers:node16.13.0-chrome95-ff94"
workflows:
  build:
    jobs:
      - cypress/install:
          executor: with-chrome
          ....
      - [your other jobs]
          executor: with-chrome
          ....
fasani-tx commented 2 years ago

Any update on this?

Node 16 is more than a year old already is LTS.

fasani-tx commented 2 years ago

This was now merged. Maybe this issue can be closed. https://github.com/cypress-io/circleci-orb/pull/376

admah commented 2 years ago

Closing this at v2.1.0 of the orb now contains this.

adam-lynch commented 2 years ago

Thanks a lot @admah!

My tests run fine. I now see the "CertVerifyProcBuiltin" error (https://github.com/cypress-io/cypress/discussions/22128). I assume this is unrelated to the executor and I've only starting seeing it because my Circle cache was cleared due to changing the Node version.