CircleCI test-deploy workflow uses end-of-life Node.js 16

cypress-io / circleci-orb

Install, cache and run Cypress.io tests on CircleCI with minimal configuration.

https://circleci.com/orbs/registry/orb/cypress-io/cypress

MIT License

159 stars 101 forks source link

CircleCI test-deploy workflow uses end-of-life Node.js 16 #448

Closed MikeMcC399 closed 1 week ago

MikeMcC399 commented 7 months ago

The CircleCI workflow .circleci/test-deploy.yml is configured to use the Docker container:

cypress/browsers:node-16.18.1-chrome-109.0.5414.74-1-ff-109.0-edge-109.0.1518.52-1

whereas the executor has been updated to node-version: "20.6.0".

Node.js 16 already reached end-of-life on Sep 11, 2023 and is no longer supported.

(Runs are logged to https://app.circleci.com/pipelines/github/cypress-io/circleci-orb.)

Suggestion

Use a minimum Node.js 18.x version compatible with the examples/angular-app version installed.

MikeMcC399 commented 7 months ago

It seems that https://app.circleci.com/pipelines/github/cypress-io/circleci-orb is not currently being triggered.

jennifer-shehane commented 7 months ago

@MikeMcC399 Yes, I did notice this. I briefly looked at it but have no idea why.

Our circleci-orb CI runs are never running. https://github.com/cypress-io/circleci-orb/pull/449
Nothing has run since a commit 2 months ago that didn’t touch the Circle config: https://app.circleci.com/pipelines/github/cypress-io/circleci-orb
The CircleCI/GitHub webhook delivery looks fine: https://github.com/cypress-io/circleci-orb/settings/hooks/62000836?tab=deliveries

jennifer-shehane commented 7 months ago

@MikeMcC399 Figured it out with some help! https://github.com/cypress-io/circleci-orb/pull/449#issuecomment-1852262850

MikeMcC399 commented 7 months ago

@jennifer-shehane

Thank you for taking a look at this. I can't be much help as I'm inexperienced with CircleCI and I don't have visibility into the CircleCI settings https://github.com/cypress-io/circleci-orb/settings either.

MikeMcC399 commented 7 months ago

Since https://github.com/cypress-io/circleci-orb/blob/aa59916d55c3e6b3bc9d6aba3b2d98971e7e9e6e/examples/angular-app/package.json#L27 is currently using Angular 15, this restricts Node.js to ^14.20.0 || ^16.13.0 || ^18.10.0 according to Angular > Version compatibility.

Angular 15 reaches end-of-life on May 18, 2024 so at some stage a migration to at least Angular 16 (supports Node.js ^16.14.0 || ^18.10.0) or preferably Angular 17 (supports Node.js ^18.13.0 || ^20.9.0) should be planned.