chore: set circleci browser tools orb to pull v1 with updates

cypress-io / circleci-orb

Install, cache and run Cypress.io tests on CircleCI with minimal configuration.

https://circleci.com/orbs/registry/orb/cypress-io/cypress

MIT License

160 stars 101 forks source link

chore: set circleci browser tools orb to pull v1 with updates #449

Closed DaleGardner closed 9 months ago

DaleGardner commented 10 months ago

Pin the version @1 so that non-breaking updates and fixes can be pulled in automatically as they arise.

cypress-app-bot commented 10 months ago

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

jennifer-shehane commented 10 months ago

@DaleGardner The tests don't appear to be running and I'm not sure why

DaleGardner commented 9 months ago

@DaleGardner The tests don't appear to be running and I'm not sure why

@jennifer-shehane My guess is that it's something to do with this being an outside collaborator contribution. All the recent pipeline runs I see are from org members. The pipelines are not even triggering so maybe the project is not set to run a pipeline for a fork?

jennifer-shehane commented 9 months ago

@DaleGardner That must be it! Updated circleci settings, let me try to commit to rerun. You forget all these little steps for newer projects.

DaleGardner commented 9 months ago

@DaleGardner That must be it! Updated circleci settings, let me try to commit to rerun. You forget all these little steps for newer projects.

@jennifer-shehane Seems like you might also need the option for setting secrets for forked builds to pass the token

jennifer-shehane commented 9 months ago

@DaleGardner We don't want to expose this secret in forked builds, but I was able to trigger this to run.

jennifer-shehane commented 9 months ago

Sorry for the delay, haven't touched this repo in a while!

sedghi commented 9 months ago

@jennifer-shehane Thanks for the merge, I think you need to manually release it as well? since I still see 3.2 being the last release

https://github.com/cypress-io/circleci-orb/releases

MikeMcC399 commented 9 months ago

There is a section in CONTRIBUTING > Releasing describing the manual steps necessary to release.

Merging a PR apparently only triggers a test-deploy in the CircleCI Pipeline.

sedghi commented 9 months ago

@MikeMcC399 Yeah need to be done by maintainers

DaleGardner commented 9 months ago

@jennifer-shehane Could we get a release created for this? Our Cypress pipelines are not able to run without this critical fix 😢

MikeMcC399 commented 9 months ago

The issue also breaks CI for the Cypress-owned repo cypress-io/cypress-example-kitchensink - see PR https://github.com/cypress-io/cypress-example-kitchensink/pull/774.