search

cypress-io / circleci-orb

Install, cache and run Cypress.io tests on CircleCI with minimal configuration.
https://circleci.com/orbs/registry/orb/cypress-io/cypress
MIT License
160 stars 101 forks source link

Orb publishing does not work for contributor PRs #451

Open jennifer-shehane opened 8 months ago

jennifer-shehane commented 8 months ago

Orb publishing doesn't work for contributor PRs since they don't have access to the CIRCLECI_TOKEN for example: https://app.circleci.com/pipelines/github/ramykl/circleci-orb/2/workflows/80a14831-88d2-49c3-9349-63efa630c614/jobs/10

MikeMcC399 commented 5 days ago

This restriction is a major disadvantage for the quality of Contributor PRs!

A regular PR runs orb-tools/lint which provides a preview of the published orb. The job is blocked for Contributor PRs until the PR is merged into master, which is really too late to be finding issues.

The whole set of checking tools described in https://github.com/CircleCI-Public/orb-tools-orb/ under Local Linting etc. also only works for owners of the Orb i.e. members of the Cypress.io organization in this case.