search

cypress-io / cypress-chrome-recorder

Export Cypress Tests from Google Chrome DevTools' Recorder
MIT License
226 stars 18 forks source link

Fix indentation #53

Closed OrKoN closed 1 year ago

OrKoN commented 1 year ago

This PR fixes the indentation issues and reworks tests to test stringifyStep and stringify separately using @puppeteer/replay. This removes the need for the LineWriterImpl. Also, removes Puppeteer as a dependency as it should not be needed.

OrKoN commented 1 year ago

cc @nagash77

emilyrohrbough commented 1 year ago

@OrKoN Thank you for the contribution! Can you link the indentation issues you are referencing? Also can you provide before & after screenshots of this fix?

OrKoN commented 1 year ago

Here is a screenshot of the current version of the Cypress extension: describe/it are not indented. For the 'after' version, you can check the test I have added "correctly stringifies an entire recording"

Screenshot 2023-03-29 at 08 26 23
cypress-app-bot commented 1 year ago

:tada: This PR is included in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: