Add Support for Wait For Element Step

cypress-io / cypress-chrome-recorder

Export Cypress Tests from Google Chrome DevTools' Recorder

MIT License

226 stars 18 forks source link

Add Support for Wait For Element Step #61

Open Who-Code opened 4 months ago

Who-Code commented 4 months ago

Currently Wait For Element Steps from Chromes .json are not generated in the cypress test file.

This PR adds the basic functionality by generating .should('be.visible') including a timeout for the selector.

CLAassistant commented 4 months ago

All committers have signed the CLA.

cypress-app-bot commented 4 months ago

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

11joselu commented 1 month ago

Any news on this?

@Who-Code first of all, thanks for adding it!. Then maybe you can clean your commits, because this project use yarn and there are already a yarn.lock file, that's means you can remove your package-lock.json, then there is console.log at line console.dir(step); 🙏🏽

And I do not know if you need to mark this PR as a Ready for Review

jennifer-shehane commented 1 month ago

@Who-Code Thanks for the contribution. I'll see if someone has time to look at this next sprint.