cypress-io / cypress-docker-images

Docker images with Cypress dependencies and browsers
https://on.cypress.io/continuous-integration
MIT License
1.02k stars 380 forks source link

chore: remove obsolete compose v1 file format version #1054

Closed MikeMcC399 closed 4 months ago

MikeMcC399 commented 4 months ago

Issue

The repo uses an obsolete version file format definition in Docker compose files:

Docker Compose outputs the following warning message when run:

version is obsolete

Background

The version definition belongs to the Compose V1 specification and is no longer supported. Compose V1 is no longer included in current releases of Docker Desktop and the final release was in May 2021.

Compose V2, the current version, released in 2020, ignores the version top-level element in the compose.yml file. See Compose history and Version top-level element (obsolete).

Change

Remove the obsolete version: file format definition from

Verification

On Ubunu 22.04.4 LTS, Node.js v20.13.1 LTS

Execute:

cd factory
docker compose build factory
docker compose build

and confirm that all images are built without errors or warnings. Continue with

cd test-project
set -a && . ../.env && set +a
docker compose run test-base

and confirm that the image builds without errors or warnings and runs successfully.

cypress-app-bot commented 4 months ago