cypress-io / cypress-docker-images

Docker images with Cypress dependencies and browsers
https://on.cypress.io/continuous-integration
MIT License
1.01k stars 376 forks source link

docs: update README Firefox not found example #1056

Closed MikeMcC399 closed 2 months ago

MikeMcC399 commented 2 months ago

Issue

README > Firefox not found refers to outdated GitHub JavaScript action versions, which use the deprecated / end-of-life node16 version:

name: E2E in custom container
on: push
jobs:
  cypress-run:
    runs-on: ubuntu-22.04
    container:
     image: cypress/browsers:node18.12.0-chrome106-ff106
     options: --user 1001
    steps:
      - uses: actions/checkout@v3
      - uses: cypress-io/github-action@v5
        with:
          browser: firefox

Change

Update the example in README > Firefox not found to use latest and supported versions:

cypress-app-bot commented 2 months ago
MikeMcC399 commented 2 months ago

Preview

https://github.com/MikeMcC399/cypress-docker-images/blob/ff-not-found-example/README.md#firefox-not-found