docs: remove global profile from contributing - Githubissues

cypress-io / cypress-docker-images

Docker images with Cypress dependencies and browsers

https://on.cypress.io/continuous-integration

MIT License

1.02k stars 380 forks source link

docs: remove global profile from contributing #1069

Closed MikeMcC399 closed 4 months ago

MikeMcC399 commented 4 months ago

Issue

CONTRIBUTING > Multi-Architecture Support contains the paragraph:

A current limitation is that no arm64 images have browser binaries - see https://github.com/cypress-io/cypress-docker-images/issues/695 for details. global-profile.sh is placed in /etc/bash.bashrc, so Arm Docker users will see a warning about this limitation.

The second sentence links to https://github.com/cypress-io/cypress-docker-images/blob/master/scripts/for-images/global-profile.sh and produces a "404 -page not found" error.

PR https://github.com/cypress-io/cypress-docker-images/pull/812 removed the file scripts/for-images/global-profile.sh and the description referring to this file is obsolete.

Change

Remove the second sentence (below) in the above paragraph from CONTRIBUTING > Multi-Architecture Support:

global-profile.sh is placed in /etc/bash.bashrc, so Arm Docker users will see a warning about this limitation.

cypress-app-bot commented 4 months ago

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.