cypress-io / cypress-docker-images

Docker images with Cypress dependencies and browsers
https://on.cypress.io/continuous-integration
MIT License
1.02k stars 380 forks source link

docs: remove obsolete problem post-install hook #1077

Closed MikeMcC399 closed 4 months ago

MikeMcC399 commented 4 months ago

Issue

README > Common problems > Cannot run post-install hook recommends using npm install --unsafe-perm.

Background

Currently the minimum supported version of Node.js is 18.x. The note relates to npm rather than Node.js itself. npm is bundled in Node.js.

The lowest Node.js 18.x version is Node.js 18.0.0 which bundles npm 8.6.0.

The npm CHANGELOG 7.0.0 > All Lifecycle Scripts says:

The user, group, uid, gid, and unsafe-perms configurations are no longer relevant. When npm is run as root, scripts are always run with the effective uid and gid of the working directory owner.

The lowest version of npm currently supported is 8.6.0 (see above). The conclusion is that the problem no longer applies to any currently supported version of npm and therefore the problem description is obsolete.

Change

Remove the obsolete section README > Common problems > Cannot run post-install hook.

MikeMcC399 commented 4 months ago

Preview

https://github.com/MikeMcC399/cypress-docker-images/blob/remove/unsafe-perm/README.md#common-problems

cypress-app-bot commented 4 months ago
MikeMcC399 commented 4 months ago

failed to solve: executor failed running [/bin/sh -c bash /opt/installScripts/node/install-node-version.sh ${APPLIED_FACTORY_DEFAULT_NODE_VERSION}]: exit code: 92