search

cypress-io / cypress-docker-images

Docker images with Cypress dependencies and browsers
https://on.cypress.io/continuous-integration
MIT License
1k stars 376 forks source link

cypress/browsers image suddenly has a /root/.ssh directory #1100

Closed babyhuey closed 1 month ago

babyhuey commented 1 month ago 
Status: Downloaded newer image for cypress/browsers:latest
root@9f55aeca3345:/# ls -lah ~/.ssh/
total 0
drwx------ 1 root root  0 Jun  4 20:19 .
drwxrwxrwx 1 root root 70 Jun  4 20:24 ..

This broke our pipelines. Easy fix on our end, but wasn't sure if this was intentional or not

MikeMcC399 commented 1 month ago

@babyhuey

Thanks for your feedback on cypress/browsers:latest from cypress/browsers on dockerhub !

Were you intending to report this change as a bug? Or were you just asking the question about whether the change was intentional?

Newly created Cypress Docker images are now based on Debian 12 instead of Debian 11 (PR https://github.com/cypress-io/cypress-docker-images/pull/1057). This has caused the change that you describe.

Installing a default Debian 12.5 bookworm system directly from https://www.debian.org/download, without using Docker, also creates the empty directory /root/.ssh.

The addition of a /root/.ssh directory is not explicitly made by the build process. It just a consequence of updated Debian packages in Debian 12.

If unplanned breaking changes are an issue for you, then it is recommended to use an explicit tag e.g.
cypress/browsers:node-20.13.1-chrome-125.0.6422.60-1-ff-126.0-edge-125.0.2535.51-1
instead of using the latest tag which is expected to include changes over time as new images are released. The documentation warns in this respect about the possibility of breaking changes being encountered if latest tags are used.

References

MikeMcC399 commented 1 month ago

Closing as the previous response provides answers for both cases of whether the original issue was intended as a bug report or as a question:

It was confirmed that Cypress Docker images are now based on Debian 12.x and that the new /root/.ssh directory is standard in this version of Debian. Therefore it is expected, is not a bug and will not be changed.

babyhuey commented 1 month ago

Yes thanks. Sorry, it was more a question to know if it was intentional or not! Much appreciated!