Closed MikeMcC399 closed 3 months ago
@jennifer-shehane
Nice. I like to have correct capitalization and terms. ☺️
The main point was to correct the mixed up usage of "container" and "image". It seemed also like the right opportunity to clean up a few other things.
There is still quite a bit of documentation work to do here. Ultimately updates are also needed in other repos like https://github.com/cypress-io/cypress-documentation & https://github.com/cypress-io/cypress-example-recipes. The descriptions on https://hub.docker.com/u/cypress will need some updates as well. One thing has led to another here. Originally I only set out to update cypress/factory
to Debian 12. 🙂
@MikeMcC399 We used to have a linter on our docs that would correct improper uses of terms based on our defintions of what to replace them with. I wish we hadnt gotten rid of it.
@jennifer-shehane
We used to have a linter on our docs that would correct improper uses of terms based on our defintions of what to replace them with. I wish we hadnt gotten rid of it.
It's quite tricky to automate, since many terms have different capitalization depending on the context e.g. "Yarn" as the package manager, yarn
as the command. If the existing texts are consistent then there's a higher chance that authors will use this as an example for new text submissions. Probably there is no escaping getting it right and checking it manually!
Issues
Use of terms in factory/README is not consistent.
The term "container" does not conform to the Docker glossary definition. The build process results in a read-only "image", whereas the run process creates a read/write "container". A Docker "image" is sometimes also referred to as a "container image".
Different terms
args
/ARG
/env
are used when referring to ARG parameters used in aDockerfile
.Branded names are referred to with incorrect capitalization.
Image / Container Image
Container
Change
Use of the terms "container" and "image" are aligned to the Docker glossary definition.
The term ARG is harmonized.
Branding capitalization / naming is corrected.
"Yarn" is changed to "Yarn v1 Classic" to avoid confusion that the term Yarn could be referring to "Yarn Modern (v2 - v4)".
References