Set up automated Docker image build

cypress-io / cypress-docker-images

Docker images with Cypress dependencies and browsers

https://on.cypress.io/continuous-integration

MIT License

1.02k stars 380 forks source link

Set up automated Docker image build #80

Closed bahmutov closed 4 years ago

bahmutov commented 5 years ago

To prevent problems like #78

stop overwriting existing Docker images. cypress/base:6, cypress/base:8 etc should stay like that forever
introduce more precise tags like cypress/base:6.16 that mirror Node image version
build Docker images on CircleCI and not manually on Docker Hub
- test built Docker images on CircleCI before pushing to Docker Hub
list SHAs of pushed images in the readme so people can find them easily?

bahmutov commented 5 years ago

Information on building Docker images on Circle

jedrichards commented 5 years ago

Agreed. This should definitely be automated - there should be a cypress/base image for every tag on https://hub.docker.com/_/node/?tab=tags at a minimum. It's a little bit ridiculous to force every project using Cypress and CI into the extremely small subset of Node/NPM/Yarn version combos currently available.

denkristoffer commented 5 years ago

stop overwriting existing Docker images. cypress/base:6, cypress/base:8 etc should stay like that forever

Wouldn't this be opposite of how node does its Docker images? node:10 currently points to 10.16.2 while a couple of days ago it would've been pointing to 10.16.1.

foxted commented 4 years ago

I believe Docker Hub has an automated build feature: https://docs.docker.com/docker-hub/builds/

bahmutov commented 4 years ago

Step 1

automate building cypress/included:x.y.z images. Probably can just run a CI job whenever we release a new version in cypress-io/cypress.

bahmutov commented 4 years ago

Step 2

automate building cypress/browsers:... images. Hmm, should we build a single image with every browser (Chrome, FF maybe Edge Beta and Brave) or separate Docker images?