search

cypress-io / cypress-docker-images

Docker images with Cypress dependencies and browsers
https://on.cypress.io/continuous-integration
MIT License
1.03k stars 380 forks source link

webkit support in docker image #916

Open psadi opened 2 years ago

psadi commented 2 years ago

What would you like?

Support for webkit & its dependencies baked into the the existing docker image

Why is this needed?

To have webkit support, This is useful for my use case as my org network doesn't connect to playwright's cdn

Other

No response

psadi commented 1 year ago

Any update on this ?

brian-mann commented 1 year ago

There are really two concerns here - caching the browser version and adding the browser dependencies for webkit.

  1. Dependencies - we should definitely add the system dependencies for running webkit in our docker images like we do for Chrome + Firefox
  2. Versioning - I don't think we'll want to version webkit inside of the docker containers because that version is coupled to the @playwright/webkit NPM module. Instead we should update our installation instructions coaching you on how to cache this in CI yourself. You don't need the webkit binary in the docker container in order to add caching on top of it (this is the same principle as all other NPM dependencies)
mikevitaler commented 1 year ago

We are running into this issue as well when trying to run our Cypress suite of tests against webkit using the official Cypress docker image. Are there any workarounds for this issue at the moment?

jennifer-shehane commented 1 year ago

Transferring this issue to docker-images repo since this is concerned with our docket-images and not the Cypress App itself.

MikeMcC399 commented 5 months ago