Closed cacieprins closed 6 months ago
@cacieprins
The HTML that gets deployed to
example.cypress.io
for, e.g., commands, should align with the tests that get scaffolded fromcypress/*
Is this an issue for this repo or for the build and deploy process defined in https://github.com/cypress-io/cypress/tree/develop/packages/example ?
@MikeMcC399 It's an issue with this repo. This PR updated the test files: https://github.com/cypress-io/cypress-example-kitchensink/pull/802/files but there is HTML that reflects the code in the test files that should be updated. https://example.cypress.io/commands/actions
@jennifer-shehane
Thanks for explaining. I see that now that you've provided the details. 👍🏻
Perhaps @rubysolo would like to follow up with a related PR to change the HTML to match the tests?
For instance, the following would need to be aligned:
Oh, I assumed those were generated. Would there be any interest in templatizing the example HTML files so that they could be autogenerated from the examples with a script?
@rubysolo We don't update these examples very often honestly, so I don't think there'd be a lot of utility with that.
One question I had -- the tests no longer call end
, since click
isn't chainable. Is there a better example of using end
that we could use in the tests / docs?
@rubysolo
One question I had -- the tests no longer call
end
, sinceclick
isn't chainable. Is there a better example of usingend
that we could use in the tests / docs?
Apparently nobody noticed that the .end
test had been deactivated. Although that achieved the goal of passing linting, it was at the expense of no longer demonstrating cy.end
.
I've raised the following interrelated issues accordingly:
I'd be in favor of removing the .end example I think.
:tada: This issue has been resolved in version 2.0.4 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
The HTML that gets deployed to
example.cypress.io
for, e.g., commands, should align with the tests that get scaffolded fromcypress/*