cypress-io / cypress-example-kitchensink

This is an example app used to showcase Cypress.io testing.
https://example.cypress.io/
MIT License
1.22k stars 2.2k forks source link

chore(deps): migrate to eslint stylistic 1.7.2 #833

Closed MikeMcC399 closed 5 months ago

MikeMcC399 commented 5 months ago

Issue

The ESLint rule indent was deprecated in ESLint v8.53.0. The ESlint documentation suggests to use the corresponding rule in @stylistic/eslint-plugin-js.

This repo uses ESLint v8.57.0 and so the deprecation already applies.

Change

  1. The npm module @stylistic/eslint-plugin-js is added using the release @stylistic/eslint-plugin-js@1.7.2.
  2. The .eslintrc configuration is changed:
    1. @stylistic/js added to plugins
    2. The indent rule is changed from https://github.com/cypress-io/cypress-example-kitchensink/blob/c06177dadc9063e3a0f91bfb35a225a1cde94a91/.eslintrc#L16 to
      "@stylistic/js/indent": ["error", 2, { "SwitchCase": 1, "MemberExpression": "off" }]

This is a refactor since the functionality remains the same, only the underlying tools are changed.

Verification

npm ci
npm run lint

Reference

cypress-app-bot commented 5 months ago
cypress-app-bot commented 5 months ago

:tada: This PR is included in version 2.0.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: