cypress-io / cypress-example-kitchensink

This is an example app used to showcase Cypress.io testing.
https://example.cypress.io/
MIT License
1.22k stars 2.2k forks source link

feat(deps): update engines to disallow node.js 21 #844

Closed MikeMcC399 closed 4 months ago

MikeMcC399 commented 4 months ago

BREAKING CHANGE:

This PR updates the engines section in package.json to

  "engines": {
    "node": "^18.0.0 || ^20.0.0 || >=22.0.0"
  }

Background

package.json

currently lists

  "engines": {
    "node": "^18.0.0 || >=20.0.0"
  }

as supported Node.js versions. This is no longer in line with the Node.js release schedule:

Verification

mkdir update-test
cd update-test
git init
npm init -y
npm install https://github.com/MikeMcC399/cypress-example-kitchensink#update/engines-node-21-eol

Check npm ci for following Node.js versions. Disallowed Node.js versions should produce a warning.

Node.js Result
v17.9.1 EBADENGINE
v18.20.3 success
v19.9.0 EBADENGINE
v20.14.0 success
v21.7.3 EBADENGINE
v22.2.0 success
cypress-app-bot commented 4 months ago
cypress-app-bot commented 4 months ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: