search

cypress-io / cypress-example-recipes

Various recipes for testing common scenarios with Cypress
https://on.cypress.io/examples
3.43k stars 1.34k forks source link

test: Update failing sort test due to ag-grid release #775

Closed tbiethman closed 2 years ago

tbiethman commented 2 years ago

It looks like the 27.3.0 release of ag-grid introduced additional elements that were throwing off our assertions. Example: https://app.circleci.com/pipelines/github/cypress-io/cypress/38160/workflows/f78c7971-2cba-462a-943f-c49aff9ec254/jobs/1544249?invite=true#step-112-7776

There are now hidden pinned columns on the left and right that include rows matching that in the body, so now there are thrice as many as we are asserting on.

I pinned the version to limit the impact of future releases of ag-grid. If we'd prefer to stay current, I could update the assertion instead, just let me know.

jaffrepaul commented 2 years ago

I think it's probably worthwhile to update the test vs. pinning the version here. Happy to review if we take that route.

tbiethman commented 2 years ago

@flotwig Correct, it was just released today: https://www.ag-grid.com/changelog/?fixVersion=27.3.0

@jaffrepaul Sounds good :+1:

flotwig commented 2 years ago

Can we do both? Otherwise this test will just fail again. Tests should be deterministic.

tbiethman commented 2 years ago

@flotwig I updated to pin the most recent version. I think the spirit of the recipe will be maintained even if this falls slightly out of date.