search

cypress-io / cypress-example-todomvc

The official TodoMVC tests written in Cypress.
MIT License
256 stars 501 forks source link

ci: update and rework main.yml #261

Closed MikeMcC399 closed 1 year ago

MikeMcC399 commented 1 year ago

This PR updates .github/workflows/main.yml with the following changes:

  1. Add workflow_dispatch to event triggers which simplifies using the workflow as a test example
  2. Change OS from windows-latest to ubuntu-22.04 which reduces the run time by a factor of 2
  3. Update actions/checkout from @v1 (released 2019) to @v3 (latest)
  4. Update cypress-io/github-action from @v4 to @v5 (latest)
  5. Remove the comment about the resolved issue https://github.com/cypress-io/cypress/issues/5466 from October 2019.
  6. Remove the line config: baseUrl=http://localhost:8888 since the baseUrl is already set in https://github.com/cypress-io/cypress-example-todomvc/blob/47493385bc1e2ce90adba94edf048bd5f09a40bd/cypress.config.ts#L7
  7. Remove the quotes for the start: and wait-on: parameters. They aren't necessary and it reads cleaner without them.