ci(deps): update GHA actions to latest

cypress-io / cypress-example-todomvc

The official TodoMVC tests written in Cypress.

MIT License

256 stars 500 forks source link

ci(deps): update GHA actions to latest #313

Closed MikeMcC399 closed 1 month ago

MikeMcC399 commented 2 months ago

Issue

.github/workflows/main.yml uses outdated versions:

actions/checkout@v3
cypress-io/github-action@v5

which causes deprecations warnings in the actions workflow logs

cypress-run Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, cypress-io/github-action@v5. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Change

Update .github/workflows/main.yml to use current versions:

cypress-app-bot commented 2 months ago

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

MikeMcC399 commented 2 months ago

CircleCI is not being triggered. It´s using a legacy version of the Cypress Orb as well:

https://github.com/cypress-io/cypress-example-todomvc/blob/e091b3de66594434ac67c95d1d2d7d0916dba717/circle.yml#L4-L8

jennifer-shehane commented 2 months ago

@MikeMcC399 We need a check to not record to the Cloud if it's a forked PR.

MikeMcC399 commented 2 months ago

@jennifer-shehane

We need a check to not record to the Cloud if it's a forked PR.

Does the functionality to record to Cypress Cloud need to be retained or could it just be removed for simplicity?

I have to pass on this one as it's related to Cypress CircleCI Orb and I just don't understand properly how this works.

MikeMcC399 commented 2 months ago

@jennifer-shehane

This could be merged even though the CircleCI workflows are failing, as the change affects only GitHub Actions.

The failures in CircleCI are not caused by any error in the PR.