cypress-io / cypress-example-todomvc

The official TodoMVC tests written in Cypress.
MIT License
256 stars 500 forks source link

ci(deps): update CircleCI Cypress Orb to v3 #314

Closed MikeMcC399 closed 2 months ago

MikeMcC399 commented 2 months ago

Issue

circle.yml uses an outdated version:

The repo is configured in the following to use Cypress 13.x

https://github.com/cypress-io/cypress-example-todomvc/blob/e091b3de66594434ac67c95d1d2d7d0916dba717/package.json#L43

A minimum of Cypress Orb v2 is however needed for Cypress v10 (and higher) compatibility.

Change

Update circle.yml to use the current version v3 of the CircleCI Cypress Orb:

cypress-app-bot commented 2 months ago
MikeMcC399 commented 2 months ago

CircleCI is not triggering. Possibly due to this being a PR from a fork?

jennifer-shehane commented 2 months ago

Yah I saw this on another PR of yours

jennifer-shehane commented 2 months ago

@MikeMcC399 I updated the circleci settings so that forked pull requests should now run.

MikeMcC399 commented 2 months ago

The workflow fails and needs further investigation:

Error calling workflow: 'build'
Error calling job: 'cypress/run'
Unexpected argument(s): start, record, executor
MikeMcC399 commented 2 months ago

The arguments for cypress/run have changed between v1 and v3 and I can't find any migration guide.

I'm closing this PR. I need to leave it to somebody with CircleCI / Cypress Orb experience.