search

cypress-io / cypress-grep

Filter tests using substring
137 stars 19 forks source link

Fix bug when only using inverted tags #149

Closed nyghtly-derek closed 1 year ago

nyghtly-derek commented 2 years ago

If I configure Cypress like this:

--env grepTags=--@exclude-me

Then I expect tests to be filtered like this:

@tag1 ~@exclude-me~ @tag2

jordanpowell88 commented 1 year ago

Hey @nyghtly-derek 👋 . Thanks for creating this PR. I apologize it's taking so long to review this. We are currently in the process of moving this repo to the main cypress repo. As a result we will archive this repo and deprecate the npm package (cypress-grep).

Moving forward though, I would love to add this change in @cyrpess/grep. Would you like to open a PR over for this work over in the main cypress repo? If not, I am happy to do it but didn't want to "steal" your hard work here!

nyghtly-derek commented 1 year ago

Hi @jordanpowell88,

I'm excited to see this happening! Hopefully I can change our npm files to use the official package soon.

I will submit that pull request to the new repo today.

jordanpowell88 commented 1 year ago

This is great to hear. Thank you!

nyghtly-derek commented 1 year ago

@jordanpowell88 https://github.com/cypress-io/cypress/pull/24413