Closed MikeMcC399 closed 8 months ago
Reverting the following changes to package.json
from https://github.com/cypress-io/cypress-realworld-app/pull/1524 allows yarn dev
to work on Windows again.
What was the intention of this change and can it be reverted without causing other side-effects?
- "start:api": "yarn tsnode --files backend/app.ts",
- "start:api:watch": "nodemon --exec yarn tsnode --watch 'backend' backend/app.ts",
+ "start:api": "NODE_ENV=development yarn tsnode --files backend/app.ts",
+ "start:api:watch": "NODE_ENV=development nodemon --exec yarn tsnode --watch 'backend' backend/app.ts",
from
$ git diff d6f7f394..6fbb8f76 package.json
diff --git a/package.json b/package.json
index bf16ea8d..9f90838f 100644
--- a/package.json
+++ b/package.json
@@ -53,6 +53,7 @@
"@babel/plugin-proposal-private-property-in-object": "7.21.11",
"@cypress/code-coverage": "^3.10.0-dev.1",
"@cypress/instrument-cra": "1.4.0",
+ "@cypress/vite-dev-server": "^5.0.7",
"@faker-js/faker": "6.1.2",
"@percy/cli": "^1.27.4",
"@percy/cypress": "3.1.2",
@@ -64,11 +65,10 @@
"@types/connect-history-api-fallback": "1.3.5",
"@types/cors": "2.8.12",
"@types/dinero.js": "1.9.0",
- "@types/express": "4.17.2",
- "@types/express-paginate": "1.0.1",
+ "@types/express": "4.17.21",
+ "@types/express-paginate": "1.0.4",
"@types/express-serve-static-core": "4.17.2",
- "@types/express-session": "1.17.4",
- "@types/faker": "5.5.9",
+ "@types/express-session": "1.18.0",
"@types/http-proxy-middleware": "0.19.3",
"@types/json-server": "0.14.4",
"@types/jsonwebtoken": "8.5.8",
@@ -76,8 +76,8 @@
"@types/lodash": "4.14.181",
"@types/lowdb": "1.0.11",
"@types/morgan": "1.9.3",
- "@types/node": "14.18.13",
- "@types/passport": "1.0.7",
+ "@types/node": "^20.11.25",
+ "@types/passport": "1.0.16",
"@types/react": "^18.2.14",
"@types/react-dom": "^18.2.6",
"@types/react-infinite-calendar": "2.3.6",
@@ -123,7 +123,7 @@
"nodemon": "2.0.22",
"npm": "^9.8.0",
"nyc": "15.1.0",
- "passport": "0.6.0",
+ "passport": "0.5.0",
"passport-local": "1.0.0",
"patch-package": "^7.0.0",
"prettier": "^3.0.0",
@@ -167,8 +167,8 @@
"test:unit": "vitest",
"test:unit:ci": "vitest --run",
"test:component:ci": "yarn cypress:run:component",
- "start:api": "yarn tsnode --files backend/app.ts",
- "start:api:watch": "nodemon --exec yarn tsnode --watch 'backend' backend/app.ts",
+ "start:api": "NODE_ENV=development yarn tsnode --files backend/app.ts",
+ "start:api:watch": "NODE_ENV=development nodemon --exec yarn tsnode --watch 'backend' backend/app.ts",
"start:react:proxy-server": "yarn tsnode scripts/testServer.ts",
"prettier": "prettier --write \"**/**.{ts,js,tsx}\" \"*.{json,md,yml}\"",
"tsnode": "nyc --silent ts-node -P tsconfig.tsnode.json",
Open to a PR here. We don't run this on windows and don't intend to run tests on it.
@jennifer-shehane
Open to a PR here. We don't run this on windows and don't intend to run tests on it.
I don't want to go against the flow if you don't intend to support RWA on Windows anymore. It has however been set up to be cross-environment compatible and, apart from the PR (#1524) which broke this, it does seem to work fine on Windows.
I have submitted https://github.com/cypress-io/cypress-realworld-app/pull/1530 to revert the script changes so RWA works on Windows again. This was a small effort to fix in this instance.
yarn dev
script fails on Windows 11.The error is:
Steps to reproduce
Windows 11 Node.js
20.11.0
Logs
Workaround
Confirm with
which should start like this: